FiveTech Support Forums

FiveWin / Harbour / xBase community
Board index FiveWin for Harbour/xHarbour xbrowse required bug fixes !
Posts: 44158
Joined: Thu Oct 06, 2005 05:47 PM
xbrowse required bug fixes !
Posted: Sun Jun 21, 2009 08:23 AM
After testing the code that we have published here:
viewtopic.php?f=3&t=15935

we have detected some errors in Class TXBrowse that must be fixed:

1) Method End() has to be renamed as Destroy(). It was wrong. And finally call return Super:Destroy()

2) This code is needed in Method CreateButtons() before the @ ..., ... :
Code (fw): Select all Collapse
 
      if ::oBtnList != nil
         ::oBtnList:End()
      endif   
      if ::oBtnElip != nil
         ::oBtnElip:End()
      endif

3) In function function TXBrows() the browse is not destroyed:
Code (fw): Select all Collapse
   if ValType( bChild ) == 'B'
      bXBr:End()
      bXBr := bChild
   endif

4) PalBmpFree() is not properly working. This function should be added:
Code (fw): Select all Collapse
 
function PalBmpFree( hBmp, hPal )

   DeleteObject( hBmp )
   DeleteObject( hPal )

return nil
regards, saludos

Antonio Linares
www.fivetechsoft.com
Posts: 6983
Joined: Fri Oct 07, 2005 07:07 PM
Re: xbrowse required bug fixes !
Posted: Sun Jun 21, 2009 08:35 AM

Hello Antonio,

what version of xBrowse is affected ?
Thanks in advance
Otto

Posts: 44158
Joined: Thu Oct 06, 2005 05:47 PM
Re: xbrowse required bug fixes !
Posted: Sun Jun 21, 2009 08:48 AM

Otto,

The Method End(), that must be Destroy(), affects to all xbrowse versions.
The PalBmpFree() may also affect to all xbrowse versions.

The others two, can't say the exact version right now. Better look in your xbrowse.prg code for those sections. Thanks,

regards, saludos

Antonio Linares
www.fivetechsoft.com
Posts: 44158
Joined: Thu Oct 06, 2005 05:47 PM
Re: xbrowse required bug fixes !
Posted: Sun Jun 21, 2009 01:58 PM
Another bug fixed:
Code (fw): Select all Collapse
METHOD End() CLASS TXBrwColumn

...

   for nFor := 1 to Len( ::aBitmaps )
      PalBmpFree( ::aBitmaps[ nFor, BITMAP_HANDLE ], ::aBitmaps[ nFor, BITMAP_PALETTE ] )
   next

return nil
regards, saludos

Antonio Linares
www.fivetechsoft.com
Posts: 90
Joined: Wed Nov 07, 2007 08:56 AM
Re: xbrowse required bug fixes !
Posted: Mon Jun 22, 2009 04:34 PM

Good :D

Posts: 190
Joined: Tue Mar 14, 2006 01:59 AM
Re: xbrowse required bug fixes !
Posted: Thu Jun 25, 2009 08:09 AM

Antonio,
do you plan to release 9.06 before the month end ?
(I'd prefer having the bugfixes already included in the standard lib rather than including another obj)
Thanks,
Davide

Posts: 44158
Joined: Thu Oct 06, 2005 05:47 PM
Re: xbrowse required bug fixes !
Posted: Thu Jun 25, 2009 10:30 AM

Davide,

We are working hard to deliver 9.06 before end of this month.

But we can't promise it yet :-)

regards, saludos

Antonio Linares
www.fivetechsoft.com

Continue the discussion