Please try this little program

test #1:
I run the program and close the window:
the result is 100 100 401 501

test #2:
I run the program, I move the window in another place on my desktop, then I close the window:
the result is 100 100 401 500 (the same result of first test

test #3:
I run the program, I move the windows changing dimension on my desktop , then I close the window( after this movements the window is roughly at the same position of test #2:
the result is 331 669 597 1083

The question is: If I only move a window without changing dimensions the four parameters
? oMain:nTop, oMain:nLeft, oMain:nBottom, oMain:nRight do not change!
Is it normal?

Many thanks

Marco

include "fivewin.ch"

FUNCTION MAIN()
LOCAL oMain
LOCAL nTw := 100 , nLw := 100 , nBw := 400 , nRw := 500

DEFINE WINDOW oMain FROM nTw , nLw TO nBw , nRw PIXEL

ACTIVATE WINDOW oMain

? STR( oMain:nTop ,4 ) + STR( oMain:nLeft ,4 ) + STR( oMain:nBottom ,4 ) + STR( oMain:nRight ,4 )

RETURN NIL

include "fivewin.ch"

FUNCTION MAIN()
LOCAL oMain
LOCAL nTw := 100 , nLw := 100 , nBw := 400 , nRw := 500

DEFINE WINDOW oMain FROM nTw , nLw TO nBw , nRw PIXEL

ACTIVATE WINDOW oMain

? STR( oMain:nTop ,4 ) + STR( oMain:nLeft ,4 ) + STR( oMain:nBottom ,4 ) + STR( oMain:nRight ,4 )

RETURN NIL

Try calling oWnd:coorsUpdate() before reading the coordinates.

James

James,
0 0 0 0

King Regards

Marco

include "fivewin.ch"

FUNCTION MAIN()
LOCAL oMain
LOCAL nTw := 100 , nLw := 100 , nBw := 400 , nRw := 500

DEFINE WINDOW oMain FROM nTw , nLw TO nBw , nRw PIXEL

ACTIVATE WINDOW oMain
oMain:coorsUpdate()
? STR( oMain:nTop ,4 ) + STR( oMain:nLeft ,4 ) + STR( oMain:nBottom ,4 ) + STR( oMain:nRight ,4 )

RETURN NIL

IT WORKS
Many thanks

Marco,

Glad to hear you got it working.

This points out a better class design would have nTop, nBottom, nLeft, and nRight as methods instead of data. This way the coordinates could be updated within the method before returning a value.

Method nTop()
local aRect := GetCoors( ::hWnd )
return aRect[1]

Or even more simply:

Method nTop()
return GetCoors(::hWnd)[1]

The downside to this design is that the GetCoors() function would have to be called four times to get all the coordinates. The upside is that you wouldn't have to remember to call the CoorsUpdate() method before using the coordinates.

Regards,
James

I added a data element ::lWndNeedCoord and ::lSaveWindow.

Then part of the window resize and move blocks I can tell if I need to save window information and when the coordinates need to be updated.
::oWnd:bMoved := { | nRow, nCol | ::lSaveWindow := .t. }
::oWnd:bResized := { | nSizeType, nWidth, nHeight | ::lSaveWindow := .t., ::lWndNeedCoord := .t., eval( ::bResize, nSizeType, nWidth, nHeight ) }

Then in my environment class that can save and restore window, splitter, and browse information I know when to update coordinates.
You have to check if the window is zoomed also. Probably iconized is another issue.

  if .not. iszoomed( ::oWnd:hWnd )
     if ::oWnd:lWndNeedCoord
        ::oWnd:CoorsUpdate()
     endif
     if ::oWnd:nTop != nil
        ::nWndTop     := ::oWnd:nTop
        ::nWndLeft    := ::oWnd:nLeft
        ::nWndBottom  := ::oWnd:nBottom
        ::nWndRight   := ::oWnd:nRight
        ::lWndNeedCoord := .f.
     endif
  endif

oWnd:bResized

GetWndRect( oWnd:hWnd ) --> gives the correct coordinates at any time.
We may use this one function instead of using combination of many methods/functions.

Alternatively, we can use oWnd:GetRect() -> oRect ( TRect object )