FiveTech Support Forums

FiveWin / Harbour / xBase community
Board indexAll discussionsLogin (GitHub)
Board index FiveWin for Harbour/xHarbour Database - 17.07 - Problems
Diego Decandia
Posts: 40
Joined: Fri Aug 22, 2014 06:21 AM
Re: Database - 17.07 - Problems
Posted: Fri Aug 25, 2017 10:04 PM

Yes, i'm using fwh 17.07

TimStone
Posts: 3022
Joined: Fri Oct 07, 2005 01:45 PM
Re: Database - 17.07 - Problems
Posted: Fri Aug 25, 2017 10:09 PM

Again, the process of elimination:

Harbour = Same Version
xHarbour = Same Version
FWH 17.07 installed
All external libraries remain the same
Source code remains the same

Substitute datamanager.prg from 17.06 and the problem is fixed. Take it away, allowing datamanager from 17.07, and problem returns.
I'm not seeing how that can be something else ... but then it is Friday afternoon after too much time looking at a computer.

Tim Stone
http://www.MasterLinkSoftware.com
http://www.autoshopwriter.com
timstone@masterlinksoftware.com
Using: FWH 23.10 with Harbour 3.2.0 / Microsoft Visual Studio Community 2022-24 32/64 bit
Diego Decandia
Posts: 40
Joined: Fri Aug 22, 2014 06:21 AM
Re: Database - 17.07 - Problems
Posted: Sat Aug 26, 2017 06:26 AM

Yes, even for me, using Tdatabase from 17.04, all seems ok and < Close clients > always works.

Diego Decandia
Posts: 40
Joined: Fri Aug 22, 2014 06:21 AM
Re: Database - 17.07 - Problems
Posted: Fri Sep 01, 2017 09:32 AM
I tried to edit TDatabase version 17.07 in this way

Code (fw): Select all Collapse
PROCEDURE td_destroy() CLASS TDataBase

//   ::End()

RETURN


and my problem does not occur. Does it also apply to other problems?
Antonio Linares
Posts: 44158
Joined: Thu Oct 06, 2005 05:47 PM
Re: Database - 17.07 - Problems
Posted: Fri Sep 01, 2017 10:58 AM

This method was recently added to Clase TDataBase:

METHOD End() INLINE ::Close()

Tim, Please remove it and try your app again, thanks

regards, saludos

Antonio Linares
www.fivetechsoft.com
Diego Decandia
Posts: 40
Joined: Fri Aug 22, 2014 06:21 AM
Re: Database - 17.07 - Problems
Posted: Fri Sep 01, 2017 11:25 AM
Removing Method End, I get

Code (fw): Select all Collapse
>>>Error BASE/1004  Message not found: TDATABASE:END
   Errore avvenuto il 01/09/17, alle 13:19:15
 
   Chiamato da: .\source\function\HARBOUR.PRG => _CLSSETERROR( 247 )
   Chiamato da: C:\fwh\source\classes\database.prg => TDATABASE:END( 913 )
   Chiamato da: C:\fwh\source\classes\database.prg => TDATABASE:__DESTRUCTOR( 1360 )
   Chiamato da:  => TDATABASE:CLASSH( 0 )
Diego Decandia
Posts: 40
Joined: Fri Aug 22, 2014 06:21 AM
Re: Database - 17.07 - Problems
Posted: Fri Sep 01, 2017 11:29 AM

Ok, removing method End and the call to ::End in td_destroy(), is ok.

Antonio Linares
Posts: 44158
Joined: Thu Oct 06, 2005 05:47 PM
Re: Database - 17.07 - Problems
Posted: Fri Sep 01, 2017 12:20 PM

Or modify it this way:

METHOD End() VIRTUAL

regards, saludos

Antonio Linares
www.fivetechsoft.com
James Bott
Posts: 4840
Joined: Fri Nov 18, 2005 04:52 PM
Re: Database - 17.07 - Problems
Posted: Fri Sep 01, 2017 02:07 PM
Antonio,

It was me that requested the End() method. The reason was to conform to polymorphism with this class. Every other class has an End() method but TDatabase only had a Close() method.

There is a new Procedure called TD_Destroy() that was also added in ver 17.07. I don't understand the reason for it. It's only purpose is to end the object and it seems to be doing this at the wrong point. I think we should review why this procedure was added.

PROCEDURE td_destroy() CLASS TDataBase

::End()

RETURN

So, if we just make the End() method virtual, it doesn't end the object and TD_Destroy does nothing. TD_Destroy is NOT being called in the object. The definition in the Class definition is:

DESTRUCTOR td_destroy()

So apparently it is being called outside the class somewhere.

James
FWH 18.05/xHarbour 1.2.3/BCC7/Windows 10
TimStone
Posts: 3022
Joined: Fri Oct 07, 2005 01:45 PM
Re: Database - 17.07 - Problems
Posted: Fri Sep 01, 2017 03:44 PM

I just did a complete FWH\Source file search, and the only place td_destroy( ) is found is in tDatabase.prg

Tim Stone
http://www.MasterLinkSoftware.com
http://www.autoshopwriter.com
timstone@masterlinksoftware.com
Using: FWH 23.10 with Harbour 3.2.0 / Microsoft Visual Studio Community 2022-24 32/64 bit
James Bott
Posts: 4840
Joined: Fri Nov 18, 2005 04:52 PM
Re: Database - 17.07 - Problems
Posted: Fri Sep 01, 2017 03:56 PM

Tim,

Try putting a msgInfo() inside the TD_Destroy procedure (before the ::end() ) and link the revised class into your code. Then recreate the error and see if the message pops up.

I would do it myself, but I have still been unable to recreate the error.

James

FWH 18.05/xHarbour 1.2.3/BCC7/Windows 10
TimStone
Posts: 3022
Joined: Fri Oct 07, 2005 01:45 PM
Re: Database - 17.07 - Problems
Posted: Fri Sep 01, 2017 04:09 PM
James Bott wrote:Tim,

Try putting a msgInfo() inside the TD_Destroy procedure (before the ::end() ) and link the revised class into your code. Then recreate the error and see if the message pops up.

I would do it myself, but I have still been unable to recreate the error.

James
unfortunately Im heading out for a few days


Sent from my iPhone using Tapatalk
Tim Stone
http://www.MasterLinkSoftware.com
http://www.autoshopwriter.com
timstone@masterlinksoftware.com
Using: FWH 23.10 with Harbour 3.2.0 / Microsoft Visual Studio Community 2022-24 32/64 bit
James Bott
Posts: 4840
Joined: Fri Nov 18, 2005 04:52 PM
Re: Database - 17.07 - Problems
Posted: Fri Sep 01, 2017 04:31 PM

Tim,

The thought just occurred to me that it is possible that Windows is calling the destroy procedure. That could explain not finding a call anywhere in the FWH code, but it still getting called.

Have a great trip!

James

FWH 18.05/xHarbour 1.2.3/BCC7/Windows 10
TimStone
Posts: 3022
Joined: Fri Oct 07, 2005 01:45 PM
Re: Database - 17.07 - Problems
Posted: Fri Sep 01, 2017 04:34 PM

Actually heading your way ... to Carlsbad ...

Tim Stone
http://www.MasterLinkSoftware.com
http://www.autoshopwriter.com
timstone@masterlinksoftware.com
Using: FWH 23.10 with Harbour 3.2.0 / Microsoft Visual Studio Community 2022-24 32/64 bit
Diego Decandia
Posts: 40
Joined: Fri Aug 22, 2014 06:21 AM
Re: Database - 17.07 - Problems
Posted: Fri Sep 01, 2017 04:50 PM

James,

In my test, opening first DLG1 that uses TDatabase, the MsgInfo appears twice before showing dialog and Xbrowse.

If I then open Dlg2 (which uses a dbf), I see the message closing.

If I first open the DLG2, no message is shown.

A bit complex...

Static archive · New replies & topics via GitHub Discussions