FiveTech Support Forums

FiveWin / Harbour / xBase community
Board index FiveWin for Harbour/xHarbour Possible TReport problem with ::NeedNewPage()
Posts: 223
Joined: Thu Dec 01, 2005 03:34 PM
Possible TReport problem with ::NeedNewPage()
Posted: Tue Oct 31, 2006 01:03 PM

Antonio,

I had a problem with occasionally getting a blank page printed out between other normal pages. So I took a close look at the way ::NeedNewPage() is implemented in TReport and found that ::nStdLineHeight gets added twice in immediate succession to ::nRow, and this seemed to be the source of my problem. Apparently it should have only been added once.

Here is how it happens...

  1. In ::EndLine()...

DEFAULT nHeight := ::nStdLineHeight

::nRow += nHeight

IF ::NeedNewPage()
::EndPage()
ENDIF

  1. In the definition of ::NeedNewPage()...

METHOD NeedNewPage INLINE ( ::nRow + ::nStdLineHeight >= ::nBottomRow )

Isn't the addition of ::nStdLineHeight in this method an unnecessary duplication of the addition of this same value immediately prior in ::EndLine() ?

Adding this value a second time sometimes pushes the value of ::nRow to a number greater than ::nBottomRow, even though the bottom of the page has actually not quite yet been reached, thereby forcing an ::EndPage() before it is actually needed.

  • Roger
Posts: 9020
Joined: Thu Oct 06, 2005 08:17 PM
Re: Possible TReport problem with ::NeedNewPage()
Posted: Tue Oct 31, 2006 05:36 PM
I agree. I always used

METHOD NeedNewPage() INLINE ( ::nRow >= ::nBottomRow )


in my customized TReport.

EMG
Posts: 44158
Joined: Thu Oct 06, 2005 05:47 PM
Possible TReport problem with ::NeedNewPage()
Posted: Wed Nov 01, 2006 08:09 AM

Roger,

>
Isn't the addition of ::nStdLineHeight in this method an unnecessary duplication of the addition of this same value immediately prior in ::EndLine() ?
>

Yes, it looks so. Is it working fine now with your fix ?

Thanks for your feedback,

regards, saludos

Antonio Linares
www.fivetechsoft.com
Posts: 223
Joined: Thu Dec 01, 2005 03:34 PM
Possible TReport problem with ::NeedNewPage()
Posted: Thu Nov 02, 2006 02:56 PM

Yes, Enrico's fix works fine. Thanks.

  • Roger

Continue the discussion